Categories fix

[Dillon]

Right now there is a bug with categories where if there are no games added to it then the site spits out a bunch of errors. On base-home.php there is no attempt to stop this, however, on browse.php there is and yet fails to work. Heres how to fix it.

On base-home.php

Code: [Select]

Search for
$baseir1 = sqlcache($sqltitle, $cachelife, $baseir2);

Add after
if(isset($baseir1)){

Now search for
<a href=\''.$playlink.'\'>Play</a></div></td>
      </tr>';
      };

Add after
}else{
echo'<tr>
<td width=\'45\' height=\'45\' valign=\'top\' class=\'content\'>
No games have been added to this category yet.
</td>
</tr>';
}

This comes up twice in the file, do it for each

On browse.php

Code: [Select]

Search for
if(!$db->num_rows($r)){
echo '<tr>
 <td colspan=\'2\' class=\'content\'>There currently are no games in this category.</td>
</tr>';
}

Replace with
if(!isset($r1)){
echo '<tr>
<td colspan=\'2\' class=\'content\'>There currently are no games in this category.</td>
</tr>';
}else{

Search for
}
$count++;
}

Add after
}


[lopa]

Keep in mind the usefulness of if (empty(Blah to create some of your arguments.

But you are right in that the errors are being generated because there is no argument to determine the status of the function.

[kurt]

This was a big reason I coded it so that categories would be created inactive by default. It gives you a chance to upload some games into it before it goes live, so that the errors didn't occur. I should have added in some error trapping as well. Sorry folks.

And thanks for the fix!

[lopa]

I just came across this where it covers all of the above and includes "Pages and Blog" also ?

http://freearcadescript.net/forums/index.php/topic,506.msg1852.html#msg1852

[Frank]

if(!isset($r1)){

isset should be used as a last resort when there are no variables to bounce an argument off.

if(empty($r1)){ etc.

Doesn't rely on url's to do the checking

[Dillon]

if(!isset($r1)){

isset should be used as a last resort when there are no variables to bounce an argument off.

if(empty($r1)){ etc.

Doesn't rely on url's to do the checking

Thanks i will look into changing it.