footer.php

[Dillon]

i do not understand the importance of this nor why it has some template.php code in there in what seems to be an early stage. All it does for me is add for annoyance from what i can see.

[kurt]

And I don't understand why I keep forgetting to take it out lol. It should no longer be needed, it was incorporated into template.php There may be a few pages still using it, but shouldn't.

[Dillon]

Ok so its safe to remove both header.php and footer.php?

[kurt]

It *should* be ok to remove it. Try renaming it first, see if something breaks lol. If ya find some page where it is still used, let me know? I went through trying to get rid of all refference to it through the include() function, but may have missed something. If it is used, you should be able to to replace it with the predefined function exit.

[Frank]

Ok so its safe to remove both header.php and footer.php?

NO IT"S NOT!

There are too many crap pieces of code that call the footer and then exit - - Viz:

      include ('templates/'.$template.'/footer.php');
exit;

I fixed some of them - And there are heaps (Just call up exit in your multi editor)


So what I did so that I didn't HAVE to keep updating all of them is this.

template.php

<?php
include "header.php";
writebody();
include "footer.php";
?>

Then what you work on is what you get.

[Dillon]

Thanks, Ill have a look at it. Also. I took your advice and im going to rewrite a lot of the code and make it a lot easier to create new templates

[Dillon]

Ok, so i figured since i brought it up here and you did say your intent is to remove it all. I decided ill post all of the files i find footer.php or header.php in the script here. So far i have found it in these file

pages/admin

• settings.php
• addpagecategory.php
• addblogcategory.php

pages/blogadmin

• index.php
• addblogcategory.php

template

• forgot_pass.php
• links.php
• login.php
• login_emailcheck.php
• messages.php
• myaccount.php
• play.php
• signup.php
• signup_emailcheck.php

That should be all the files that contain this. Also when i delete it do i delete

include ('templates/'.$template.'/footer.php');
exit;

or just

include ('templates/'.$template.'/footer.php');

[Frank]

From what I can see this needs to be carefully gone through and could take some time with testing what's missing and what's not.

It's the pop-up type messages that break the footer, fixing that would be a better idea.

At monster games - Add a game to your favourites without logging in - - You'll get what I mean, and you can practice with that.

Anyway - Kurt has suggested something to try - So try that, because I don't have the time to worry about that at the moment.

[Frank]

Oh! and if you're going to re-write the template - use the one I sent you if you wish. Because if you want to modify that etc, etc - you'll still have lots to do.

[Frank]

I've had a look at at least one of these and I wont go into the if's and buts, but as I understand it - Adam is supposed to have done all this for the next version?

addfavorites.php

Replace all the text with this:

Code: [Select]

<?php
function writebody() {
global $db, $domain, $sitename, $con1, $suserid, $userid, $userdata;

if(!isset($suserid)){
echo '<div class=\'error\'>Please login first.</div>';

}else{

if(isset($suserid)){
}
$ID = clean($_GET['cmd']);
$ID = abs((int) ($ID));

$db->query(sprintf('INSERT INTO dd_user_favorites SET
userid=\'%u\',
gameid=\'%u\'', $suserid, $ID));

echo '<div class=\'msg\'>Game added to your favorites.</div>';
$pgname = 'Add to favorites';
}
};
?>
One down - 100 to go!  

[kurt]

... Also when i delete it do i delete

include ('templates/'.$template.'/footer.php');
exit;

or just

include ('templates/'.$template.'/footer.php');

Leave in the "exit;" and just delete the include statement.

I'm working my way through the files now and correcting them, but only on 2.0, not 2.1.

[Dillon]

... Also when i delete it do i delete

include ('templates/'.$template.'/footer.php');
exit;

or just

include ('templates/'.$template.'/footer.php');

Leave in the "exit;" and just delete the include statement.

I'm working my way through the files now and correcting them, but only on 2.0, not 2.1.

Thats ok im not going to re download them my site is way to edited for that. lol

[kurt]

Didn't figure you would. But I was saying that for the sake of others who have yet to even set up their sites. If they hold off a few more minutes I should be finished.

[Frank]

And if you simply remove the "exit" you will end up with two footers every time  those particular messages are generated.